[SQL] add support for backup storage redundancy param to create/restore/update db commands #15341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaliciayang
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
Collaborator
|
SQL |
Juliehzl
reviewed
Sep 30, 2020
| 'LRS': 'Local', | ||
| 'GRS': 'Geo', | ||
| 'ZRS': 'Zone' | ||
| }.get(self, 'Invalid') |
Contributor
There was a problem hiding this comment.
could you add support like https://github.com/Azure/azure-cli/pull/15208/files
Juliehzl
reviewed
Sep 30, 2020
Juliehzl
reviewed
Sep 30, 2020
Comment on lines
661
to
665
| c.argument('storage_account_type', | ||
| arg_type=backup_storage_redundancy_param_type, | ||
| options_list=['--backup-storage-redundancy', '--bsr'], | ||
| help='Backup storage redundancy used to store backups') | ||
|
|
Contributor
There was a problem hiding this comment.
avoid duplicate. use CLIArgumentType to abstract common argument type and reuse it for command
Juliehzl
reviewed
Sep 30, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Juliehzl
approved these changes
Oct 9, 2020
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling customer to set Backup Storage Redundancy (StorageAccountType in REST API) via --backup-storage-redundancy parameter by adding parameter to the following cmds:
az sql db create
az sql db update
az sql db restore
az sql db copy
az sql db replica create
az sql db ltr-backup restore
Testing Guide
Test all of the above commands with additional --backup-storage-redundancy parameters
History Notes
[SQL] BREAKING CHANGE: az sql db create: Add --backup-storage-redundancy parameter; add warning for unspecified bsr/bsr == Geo.
Same for remaining cmds.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.